Skip to content

Modularize particle DG discretization #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbreue16 merged 2 commits into from
May 19, 2025
Merged

Modularize particle DG discretization #406

jbreue16 merged 2 commits into from
May 19, 2025

Conversation

@jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented May 6, 2025 •
edited
Loading

TODO

  • outsource all the particle discretization related code from the GRM_DG unit to a new ParticleDispersionOperator
    • outsource operators and parDiff residual
    • outsource Jacobian
    • outsource write particle coordinates
    • filmDiff Jac
    • outsource parameters & registration, sensitivities, updateRadialDisc
    • test changes, including parameter sensitivities; added (and expanded) sensitivities to CI and CADET-Verification#50; results of commit were compared to verification output
    • run performance benchmark. To this end, add performance visualizations to cadet-verification

@jbreue16 jbreue16 self-assigned this May 6, 2025
@jbreue16 jbreue16 mentioned this pull request May 6, 2025
Open
23 tasks
jbreue16 added a commit that referenced this pull request May 6, 2025
@jbreue16
Add numerical reference test for 2DLRMP to CI (#406)
6e77217
jbreue16 added a commit that referenced this pull request May 6, 2025
@jbreue16
Rename nCol to nElem in DG units (#406)
67a46eb
@jbreue16 jbreue16 force-pushed the feature/dg2d branch 7 times, most recently from 04431ed to b1dd002 Compare May 13, 2025 08:46
schmoelder
schmoelder reviewed May 13, 2025
View reviewed changes
@jbreue16 jbreue16 mentioned this pull request May 15, 2025
Merged
jbreue16 added a commit that referenced this pull request May 15, 2025
@jbreue16
Modularize particle DG discretization (#406)
f0ef933
@jbreue16
Copy link
Contributor Author

jbreue16 commented May 19, 2025 •
edited
Loading

Performance benchmark data attached for commit f0ef933, showing no decrease in performance.
The code is here
convergence_GRM_dynLin_1comp_sensbenchmark1
convergence_GRM_dynLin_1comp_sensbenchmark2
convergence_GRM_reqSMA_4comp_sensbenchmark1

@jbreue16 jbreue16 changed the base branch from master to jb/dev May 19, 2025 11:28
@jbreue16 jbreue16 merged commit cfcae25 into jb/dev May 19, 2025
4 checks passed
jbreue16 added a commit that referenced this pull request May 19, 2025
@jbreue16
Modularize particle DG discretization (#406)
eac2143
@github-project-automation github-project-automation bot moved this from Todo to Done in CADET Repositories May 19, 2025
@jbreue16 jbreue16 deleted the feature/dg2d branch May 19, 2025 11:42
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@schmoelder schmoelder schmoelder left review comments

Assignees

@jbreue16 jbreue16

Labels

enhancement numerics

Projects

CADET Repositories
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbreue16 @schmoelder